Thread (61 messages) flat view 61 messages, 6 authors, 2021-09-27

Re: [PATCH 4/7] grep: read submodule entry with explicit repo

From: Jonathan Tan <hidden>
Date: 2021-08-13 16:39:05

quoted
-		object = parse_object_or_die(oid, NULL);
+		object_type = oid_object_info(&subrepo, oid, NULL);
One thing I wonder is whether we are missing out on some error
conditions we used to get with parse_object_or_die() by using
oid_object_info() instead. Do we need to be more defensive in
investigating 'oid' before calling that helper, now?
For the purposes of grep, I don't think that this matters - we just want
to find the ultimate tree that this object represents.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help