Thread (61 messages) 61 messages, 6 authors, 2021-09-27

Re: [PATCH 3/7] grep: typesafe versions of grep_source_init

flat view

From: Jonathan Tan <hidden>
Date: 2021-08-13 16:32:46

Just a quick note: grep_source_init_buf() is only called from
grep.c:1833, before its definition at grep.c:1869, so it could be marked
as static (as things stand). Do you anticipate any future callers from
outside of grep.c? (after removing the declaration from grep.h, you
would need to add a forward declaration or, better, move the definition
to before the call (or the call (and grep_buffer()) after the definition)).
No, I do not - thanks for the note, and I'll make it static in the next
reroll.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help