Re: [RFC PATCH 01/13] serve: add command to advertise bundle URIs
From: Derrick Stolee <hidden>
Date: 2021-08-10 13:58:58
On 8/5/2021 11:07 AM, Ævar Arnfjörð Bjarmason wrote: ...
+bundle-uri CLIENT AND SERVER EXPECTATIONS +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ + +The advertised bundles MUST contain one or more reference tips for use +by the client. Bundles that are not self-contained MUST use the +standard "-" prefixes in the bundle format to indicate their +prerequisites. I.e. they must be in the standard format "git bundle +create" would create. + +If after an `ls-refs` the client finds that the ref tips it wants can +be retrieved entirety from advertised bundle(s), it MAY +disconnect. The results of such a "clone" or "fetch" should be +indistinguishable from the state attained without using bundle-uri. + +The client MAY also keep the connection open pending download of the +bundle-uris, e.g. should on or more downloads (or their validation) +fail.
The only technical thought I had (so far) about this proposal was that leaving the connection open while downloading the bundle would leave unnecessary load on the servers when no communication is happening. There is a cost to keeping an open SSH connection, so here it would be good to at least have the Git client close the connection after getting a 200 response from the bundle (but not waiting for all of its contents). Thanks, -Stolee