Re: [PATCH v2 2/3] test-lib-functions.sh: add a test_with_columns function

On Mon, Aug 2, 2021 at 1:14 PM SZEDER Gábor [off-list ref] wrote:

On Mon, Aug 02, 2021 at 03:46:27PM +0200, Ævar Arnfjörð Bjarmason wrote:

quoted

+# Test a with a given number of COLUMNS in the environment.
+test_with_columns () {
+     local columns=$1
+     shift
+
+     COLUMNS=$columns "$@"
+}

This function needs some redirections to separate the tested command's
standard error from the function's '-x' trace, see a5bf824f3b (t:
prevent '-x' tracing from interfering with test helpers' stderr,
2018-02-25).

This is also potentially problematic when a test is expected to fail,
in which case we avoid the:

    FOO=bar command

idiom and instead use:

    test_must_fail env FOO=bar command