Re: progress test failure on fedora34

On Mon, Jul 19, 2021 at 11:18 AM Alex Henrie [off-list ref] wrote:

On Sun, Jul 18, 2021 at 2:08 AM Ævar Arnfjörð Bjarmason
[off-list ref] wrote:

quoted

On Wed, Jul 14 2021, Alex Henrie wrote:

quoted

On Wed, Jul 14, 2021 at 9:39 AM Ævar Arnfjörð Bjarmason
[off-list ref] wrote:

quoted

On Wed, Jul 14 2021, Fabian Stelzer wrote:

quoted

Hi,
The test t0500-progress-display.sh in current master fails on latest
fedora34.
The break was introduced with:

83ae1edff7ee0b7674bd556955d2cf1706bddb21
ab/fix-columns-to-80-during-tests (2021-06-29) 1 commit

Kind regards,
Fabian

I have not been able to reproduce this, it seems the below E-Mail was
word-wrapped by your mailer, which is especially bad here since getting
to the bottom of this requires looking at the whitespace.

Is there a way you could tar that up and send it (to me personally is
fine, or some pastebin or whatever).

I am able to reproduce something that looks like this if I
s/COLUMNS=80/COLUMNS=79/g in the test-lib, but given that we set it to
80, and that the progress.c code just ends up with an
atoi(getenv("COLUMNS")), and we do our own wrapping (with no other fancy
logic) in progress.c, I'm not seeing right now how this could happen...

This test also fails for me when using QTerminal or Konsole, but it
passes on XTerm and LXTerminal.

I tried this on Debian 11 with QTerminal 0.16.1 and can't reproduce it,
resized the window etc., always get COLUMNS=80 if I add some printf
debugging.

Actually, it looks like the difference was that I didn't resize the
XTerm or LXTerminal windows. The tests pass on all four if the
terminal emulator window is exactly 80 columns wide, and they fail on
all four if the window is any wider or narrower.

I have narrowed the problem down to the `tput` command in test-lib.sh:
When `tput` runs, $COLUMNS is reset to the width of the terminal
emulator window.

-Alex