Thread (4 messages) 4 messages, 2 authors, 2021-07-27

Re: ref-in-want does not consider namespace

flat view

From: Jonathan Tan <hidden>
Date: 2021-07-26 16:47:16

quoted
Running `ls-refs` with a namespace-relative

`ref-prefix refs/heads/*`

will work as expected
That turned out to not be entirely true: it does work as expected with a
2.31.1 install, but fails to select any refs with 2.20.1.
Your expectation that "want-ref refs/heads/main" should match
"refs/namespaces/foo/refs/heads/main" when you run upload-pack with
"--namespace=foo" makes sense to me. Just to clarify - does this mean
tha 2.31.1 works like you expect?

In any case, t5703 should contain a namespace test, but it doesn't seem
to. We could just use the one in my original patch [1] (thanks for
looking it up, by the way). Would you be able to contribute a patch? I
see that in [1], I had my own helpers to construct the input, but
"test-tool pkt-line" now exists (as you can see in t5703) so you can do
that instead.

[1] https://lore.kernel.org/git/d0d42b3bb4cf755f122591e191354c53848f197d.1485381677.git.jonathantanmy@google.com/ (local)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help