Thread (56 messages) flat view 56 messages, 7 authors, 2021-08-24

Re: [PATCH 0/5] serve: add "configure" callback

From: Jeff King <hidden>
Date: 2021-06-16 16:23:42

On Wed, Jun 16, 2021 at 04:16:16PM +0200, Ævar Arnfjörð Bjarmason wrote:
This is a refactoring of what a callback in serve.c needs to do to
aquire config. Currently two of them want that, and grab it in ad-hoc
ways themselves, now they can insted configure a "configure" callback
along with the existing "advertise" and "command", by the time they're
called their config will already be read with their callback.

I split this prep work off from an upcoming series where I wanted to
add a new capability, but I think this stands nicely on its own, and
simplifies the existing code.
The first four seem like obviously-good cleanups. I'm not so sure
about the last one, though. I left some comments there.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help