Re: [PATCH 3/4] *: fix typos
flat view
From: Johannes Schindelin <hidden>
Date: 2021-06-10 08:36:41
Hi, On Mon, 7 Jun 2021, Derrick Stolee via GitGitGadget wrote:
quoted hunk ↗ jump to hunk
diff --git a/t/t9300-fast-import.sh b/t/t9300-fast-import.sh index 5c47ac4465cb..7039b5c6028d 100755 --- a/t/t9300-fast-import.sh +++ b/t/t9300-fast-import.sh@@ -1538,7 +1538,7 @@ test_expect_success 'O: comments are all skipped' ' commit refs/heads/O1 # -- ignore all of this text committer $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> $GIT_COMMITTER_DATE - # $GIT_COMMITTER_NAME has inserted here for his benefit. + # $GIT_COMMITTER_NAME has inserted here for this benefit.
What is this even supposed to mean? I fail to parse that sentence in both original and modified forms. Looking at 401d53fa350 (Teach fast-import to ignore lines starting with '#', 2007-08-01), where the comment was added, I deduce from the commit message that the personal pronoun _was_ actually intended. So maybe a better way to express the original intent would be this: # comment added by $GIT_COMMITTER_NAME; fast-import should ignore it Ciao, Dscho