Re: [PATCH 02/11] doc: doc-diff: allow more than one flag
From: Jeff King <hidden>
Date: 2021-05-15 09:37:52
On Fri, May 14, 2021 at 07:14:26AM -0500, Felipe Contreras wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Felipe Contreras <redacted> --- Documentation/doc-diff | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/Documentation/doc-diff b/Documentation/doc-diff index 1694300e50..ecd88b0524 100755 --- a/Documentation/doc-diff +++ b/Documentation/doc-diff@@ -146,7 +146,7 @@ render_tree () { # through. oid=$1 && dname=$2 && - makemanflags=$3 && + makemanflags="$3" &&
This line does nothing; the shell won't split whitespace here either way.
quoted hunk ↗ jump to hunk
@@ -181,6 +181,6 @@ render_tree () { fi } -render_tree $from_oid $from_dir $from_makemanflags && -render_tree $to_oid $to_dir $to_makemanflags && +render_tree $from_oid $from_dir "$from_makemanflags" && +render_tree $to_oid $to_dir "$to_makemanflags" &&
This part is necessary (and sufficient). It would be nice to mention in the commit message why the use of $makemanflags in render_tree must remain unquoted (as I did in mine when I made the same change). -Peff