Re: [PATCH 03/11] doc: doc-diff: set docdate manually

Martin Ågren wrote:

On Fri, 14 May 2021 at 14:14, Felipe Contreras [off-list ref] wrote:

quoted

Asciidoc automatically generates a date with format '%Y-%m-%d', while
asciidoctor '%F'.

Is that really the format Asciidoc uses? Not that it matters much for
the purposes of this patch.

Yes:

https://github.com/asciidoc-py/asciidoc-py/blob/main/asciidoc/asciidoc.py#L1189

quoted

I personally prefer the latter, so only modify it for diff purposes.

I agree completely.

quoted

Fixes tons of these:

-Git omitted                       01/01/1970                        GIT-ADD(1)
+Git omitted                       1970-01-01                        GIT-ADD(1)

quoted

        then
-               echo USE_ASCIIDOCTOR=YesPlease
+               echo USE_ASCIIDOCTOR=YesPlease ASCIIDOC_EXTRA='-adocdate="01/01/1970"'
        fi

Nice.

If you introduce a separate Makefile flag and incorporate Peff's patch
to doc-diff "asciidoctor" and "asciidoctor-direct", you'd need to
duplicate this a bit, or maybe just emit the ASCIIDOC_EXTRA outside of
the whole if chain.

Indeed.

You could follow up with the patch below. If you'd rather keep it out of
your series to avoid it ballooning, fine. I can repost it later, once
the dust has settled. Don't let it hold up your work.

I'll include it. Seems to fit the context.

Cheers.

-- 
Felipe Contreras