Re: [PATCH v2 3/8] object.c: add and use oid_is_type_or_die_msg() function
From: Josh Steadmon <hidden>
Date: 2021-04-21 23:28:45
On 2021.04.20 15:36, Ævar Arnfjörð Bjarmason wrote:
quoted hunk ↗ jump to hunk
diff --git a/object.c b/object.c index 9e06c0ee92..0f07f976fb 100644 --- a/object.c +++ b/object.c@@ -176,6 +176,18 @@ int oid_is_type_or_error(const struct object_id *oid, type_name(want)); } +char* oid_is_type_or_die_msg(const struct object_id *oid,
It's kind of a nitpick, but I found the function name to be confusing. It sounds like you're going to die with a custom message. Maybe something like "get_oid_type_mismatch_msg()" would be more straightforward.