Thread (48 messages) flat view 48 messages, 5 authors, 2021-04-15

Re: [PATCH 1/2] diff tests: remove redundant case statement

From: Matheus Tavares Bernardino <hidden>
Date: 2021-04-13 14:19:11

On Tue, Apr 13, 2021 at 9:31 AM Ævar Arnfjörð Bjarmason
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/t/t4013-diff-various.sh b/t/t4013-diff-various.sh
index 6cca8b84a6b..67f6411aff9 100755
--- a/t/t4013-diff-various.sh
+++ b/t/t4013-diff-various.sh
@@ -220,13 +220,7 @@ do
                then
                        process_diffs "$actual" >actual &&
                        process_diffs "$expect" >expect &&
-                       case $cmd in
-                       *format-patch* | *-stat*)
-                               test_cmp expect actual;;
-                       *)
-                               test_cmp expect actual;;
-                       esac &&
-                       rm -f "$actual" actual expect
Was this line removed by accident? It doesn't seem related to the
described change. Shouldn't this line be left after...
+                       test_cmp expect actual
...this one?
                else
                        # this is to help developing new tests.
                        cp "$actual" "$expect"
--
2.31.1.646.g06d606cb9c7
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help