Re: [PATCH] mktag tests: fix broken "&&" chain
From: SZEDER Gábor <hidden>
Date: 2021-03-07 16:38:03
Possibly related (same subject, not in this thread)
- 2021-03-07 · Re: [PATCH] mktag tests: fix broken "&&" chain · Eric Sunshine <hidden>
- 2021-03-07 · Re: [PATCH] mktag tests: fix broken "&&" chain · Junio C Hamano <hidden>
On Sun, Mar 07, 2021 at 02:29:05PM +0100, Ævar Arnfjörð Bjarmason wrote:
Remove a stray "xb" I inadvertently introduced in 780aa0a21e0 (tests: remove last uses of GIT_TEST_GETTEXT_POISON=false, 2021-02-11). This would have been a failed attempt to type "C-x C-b" that snuck into the code. The chainlint check did not catch this one, but I don't know where to start patching the wall-of-sed that is chainlint.sed to fix that.
Chain-lint only checks 'test_expect_{success,failure}' blocks, but
this && chain is in a helper function.
quoted hunk ↗ jump to hunk
Signed-off-by: Ævar Arnfjörð Bjarmason <redacted> --- t/t3800-mktag.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/t/t3800-mktag.sh b/t/t3800-mktag.sh index 60a666da595..6275c98523f 100755 --- a/t/t3800-mktag.sh +++ b/t/t3800-mktag.sh@@ -17,7 +17,7 @@ check_verify_failure () { grep '$2' message && if test '$3' != '--no-strict' then - test_must_fail git mktag --no-strict <tag.sig 2>message.no-strict &&xb + test_must_fail git mktag --no-strict <tag.sig 2>message.no-strict && grep '$2' message.no-strict fi "-- 2.31.0.rc0.126.g04f22c5b82