Thread (59 messages) 59 messages, 9 authors, 2021-04-16

Re: [PATCH v2 1/5] maintenance: simplify prefetch logic

From: Emily Shaffer <hidden>
Date: 2021-04-07 23:23:33

Overall, the series looks pretty solid to me - which is why I've got a
handful of small nits to relay. :)

On Tue, Apr 06, 2021 at 06:47:46PM +0000, Derrick Stolee via GitGitGadget wrote:
-static int fetch_remote(const char *remote, struct maintenance_run_opts *opts)
+static int fetch_remote(struct remote *remote, void *cbdata)
 {
+	struct maintenance_run_opts *opts = cbdata;
[snip]
 	if (opts->quiet)
I worry about the lack of null-checking here.

 - Emily
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help