Re: [PATCH v4 07/20] test-read-cache: print cache entries with --table

Hi,

On Sun, Mar 28, 2021 at 8:31 AM Ævar Arnfjörð Bjarmason
[off-list ref] wrote:

On Fri, Mar 26 2021, Elijah Newren wrote:

[...]

quoted

You are correct that this will span multiple releases; Stolee already
said he was planning to be working on this for most of 2021.  But just
because pieces of the code exist and are shipped doesn't mean it'll be
announced or supported.  For example, the git-2.30 and git-2.31
release notes were completely silent about merge-ort.  It existed in
both releases; in fact, the version that ships in git-2.31, could
theoretically be used successfully by the vast majority of users for
their daily workflow.  (But it does have known shortcomings and test
failures so I definitely did *not* want it to be announced at that
time.)

Yes, and that's fine. But if you'd been bending over backwards to add
merge-ort to t/helper/ "because it's not ready yet" or something I'd
have probably commented to the effect of "can't we just add it as part
of builtins but not advertise it?" which is what you did :)

Actually, I did add a t/helper/test-fast-rebase.c (which is a few
hundred lines long) as part of the work on merge-ort, because
merge-ort wasn't ready and because rewiring sequencer.c was a huge
amount of work that I didn't want to get distracted by at the time.  I
originally suggested making fast-rebase a non-advertised builtin, but
multiple reviewers suggested the test helper route instead.

¯\_(ツ)_/¯