Re: [PATCH 02/20] t/perf: add performance test for sparse operations

On 2/23/2021 9:30 PM, Elijah Newren wrote:

On Tue, Feb 23, 2021 at 12:14 PM Derrick Stolee via GitGitGadget
[off-list ref] wrote:
+test_expect_success 'setup repo and indexes' '
+       git reset --hard HEAD &&
+       # Remove submodules from the example repo, because our
+       # duplication of the entire repo creates an unlikly data shape.
+       git config --file .gitmodules --get-regexp "submodule.*.path" >modules &&
+       rm -f .gitmodules &&
+       git add .gitmodules &&
Why not `git rm [-f] .gitmodules` instead of these two commands?  Is
there something special about .gitmodules that requires this special
handling?

No, I'm just being sloppy. Will clean up.

quoted

+       for module in $(awk "{print \$2}" modules)
+       do
+               git rm $module || return 1
+       done &&
+       git add . &&

What does the `git add .` do?  I don't see any changes there weren't
already git-add'ed or git-rm'ed.

Same here. Thanks.

-Stolee