Thread (39 messages) 39 messages, 3 authors, 2021-03-15

Re: [PATCH v3 0/8] Optimization batch 9: avoid detecting irrelevant renames

From: Derrick Stolee <hidden>
Date: 2021-03-15 13:58:05

On 3/10/2021 7:38 PM, Elijah Newren via GitGitGadget wrote:
This series determines paths which meet special cases where detection of
renames is irrelevant, where the irrelevance is due to the fact that the
merge machinery will arrive at the same result regardless of whether a
rename is detected for any of those paths.

Changes since v2:

 * Added an extended comment about filtering order to the first patch, to
   address Stolee's question
 * Added a new testcase that will fail if the critical "if (content_relevant
   || location_relevant)" check only checks for one of those two or the
   intersection of those two, as suggested by Stolee
 * Fixed the other minor problems Stolee pointed out in his review (stray
   newline, wording of comment)
Thanks for these updates. This version works for me.

-Stolee
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help