Thread (39 messages) 39 messages, 3 authors, 2021-03-15

Re: [PATCH v2 7/8] merge-ort: skip rename detection entirely if possible

flat view

From: Elijah Newren <hidden>
Date: 2021-03-09 22:58:42

On Tue, Mar 9, 2021 at 2:51 PM Derrick Stolee [off-list ref] wrote:
On 3/8/2021 7:09 PM, Elijah Newren via GitGitGadget wrote:> +   goto simple_cleanup; /* collect_renames() handles some of cleanup */
quoted
+
+cleanup:
+     /*
+      * Free now unneeded filepairs, which would have been handled
+      * in collect_renames() normally but we're about to skip that
+      * code...
+      */
"but we're about to skip that code"

Haven't you skipped it already, earlier in the above part? This should
instead say "but we skipped that code", right?
Oh, indeed.  I wonder if I moved that comment around and didn't update
it.  Anyway yes, I'll fix it.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help