Thread (107 messages) flat view 107 messages, 5 authors, 2021-03-11

Re: [PATCH 1/3] t7003: test ref rewriting explicitly

From: Jeff King <hidden>
Date: 2021-03-11 02:25:13

On Thu, Mar 11, 2021 at 01:55:04AM +0000, brian m. carlson wrote:
On 2021-03-11 at 00:10:29, Ævar Arnfjörð Bjarmason wrote:
quoted
On Wed, Mar 10 2021, Jeff King wrote:


I've read it all over, looks good to me.
quoted
Note these all pass currently, but the latter two will fail when run
with GIT_TEST_DEFAULT_HASH=sha256.
I don't know if anyone relies on that. Probably fine to have this as-is.
Our CI runs that way, and I always use that mode.  Are you saying that
these will always fail in that mode, or that they will pass at the end
of the series?
The latter; everything passes at the end. The only thing that is hurt is
if we care about bisecting the tests with GIT_TEST_DEFAULT_HASH set

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help