Thread (107 messages) 107 messages, 5 authors, 2021-03-11

Re: [PATCH v6 00/39] SHA-256, part 3/3

From: Jeff King <hidden>
Date: 2021-03-10 17:09:49

On Wed, Mar 10, 2021 at 08:36:15AM -0800, Elijah Newren wrote:
Honestly not sure it's worth bothering fixing filter-branch at this
point, given the strong WARNINGs we added to it.  If anything, I'd
just add another warning to the pile for this issue.  If folks really
still want/need filter-branch once SHA-256 is the only option, I'm
sure they'll be motivated to make the necessary fixes (or just use/fix
filter-repo's filter-branch-ish).
You're probably right that it's not a good use of time, but I just sent
a series fixing it. It was one of those cases where I was like "oh, it's
probably just X". And then "no, wait...", and before I knew it I had
wasted an hour fixing filter-branch. ;)

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help