Re: [PATCH v2 2/4] http-fetch: allow custom index-pack args
From: Jonathan Nieder <hidden>
Date: 2021-03-05 00:19:22
Hi Jonathan, Jonathan Tan wrote:
This is the next step in teaching fetch-pack to pass its index-pack arguments when processing packfiles referenced by URIs. The "--keep" in fetch-pack.c will be replaced with a full message in a subsequent commit. Signed-off-by: Jonathan Tan <redacted> Signed-off-by: Junio C Hamano <redacted> --- Documentation/git-http-fetch.txt | 10 ++++++++-- fetch-pack.c | 3 +++ http-fetch.c | 20 +++++++++++++++----- t/t5550-http-fetch-dumb.sh | 5 ++++- 4 files changed, 30 insertions(+), 8 deletions(-)
This is producing an interesting symptom for me: git init repro cd repro git config fetch.uriprotocols https git config remote.origin.url https://fuchsia.googlesource.com/fuchsia git config remote.origin.fetch +refs/heads/*:refs/remotes/origin/* git fetch -p origin Expected result: fetches Actual result: fatal: pack has bad object at offset 12: unknown object type 5 fatal: finish_http_pack_request gave result -1 fatal: fetch-pack: expected keep then TAB at start of http-fetch output Thanks to Nathan Mulcahey (cc-ed) for a clear report. Bisects to b664e9ffa153189dae9b88f32d1c5fedcf85056a, which is part of "next" and 2.31.0-rc1. Another report of the same is at https://crbug.com/1184814. Known problem? Thanks, Jonathan