On 3/17/2021 2:20 PM, Ævar Arnfjörð Bjarmason wrote:

A v5 with changes suggested by Derrick Stolee. Link to v4:
https://lore.kernel.org/git/20210316161738.30254-1-avarab@gmail.com/ (local)

Changes:

 * 1/19 is new, it's a simple refactoring of some git_config() code in
   fsck.c code I changed recently.

This new patch is simple, as advertised.
 

 * Squashed the first 4x patches of incrementally redefining two
   macros into one.

Thanks.

 * Squashed a whitespace-only change into another patch that changed
   the same code.

 * Got rid of fsck-cb.c, that one function just lives at the bottom of
   fsck.c now.

I was late in giving you confirmation that fsck.c is a good place,
but you got there, anyway. Thanks!

This version LGTM.

-Stolee