Thread (6 messages) 6 messages, 3 authors, 2021-02-26

Re: [PATCH] wrapper: add workaround for open() returning EINTR

From: Johannes Sixt <hidden>
Date: 2021-02-24 07:21:24

Am 24.02.21 um 05:43 schrieb Jeff King:
The workaround here is enabled all the time, without a Makefile knob,
since it's a complete noop if open() never returns EINTR. I did push it
into its own compat/ source file, though, since it has to #undef our
macro redirection. Putting it in a file with other code risks confusion
if more code is added after that #undef.
I'm not so much opposed to "enable it all the time" in general, but when
we already have an override of open(), like for the Windows case in
compat/mingw.h, I find it a bit rough to put another wrapper around it,
even more so since we won't have the EINTR problem on Windows due to the
absence of signals.

-- Hannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help