Re: [PATCH] wrapper: add workaround for open() returning EINTR

On Tue, Feb 23, 2021 at 11:43:15PM -0500, Jeff King wrote:

The workaround here is enabled all the time, without a Makefile knob,
since it's a complete noop if open() never returns EINTR. I did push it
into its own compat/ source file, though, since it has to #undef our
macro redirection. Putting it in a file with other code risks confusion
if more code is added after that #undef.

Hmm. The patch below defines it in wrapper.c. Intentional?

I do still think the OS is doing the wrong thing here. But even if I'm
right, it's probably prudent to work around it.

Regardless of the above, I agree that if your explanation is true (and I
have no reason to believe that it isn't) that the OS is indeed doing the
wrong thing here.

That patch below looks quite reasonable, thanks.


Thanks,
Taylor