On Fri, Jan 29, 2021 at 03:19:31PM -0500, Eric Sunshine wrote:
On Fri, Jan 29, 2021 at 3:07 PM Jeff King [off-list ref] wrote:
quoted
Subject: [PATCH] p5303: avoid sed GNU-ism
Using "1~5" isn't portable. Nobody seems to have noticed, since perhaps
people don't tend to run the perf suite on more exotic platforms. Still,
it's better to set a good example.
It's not just exotic platforms on which this can be a problem. BSD
lineage `sed`, such as stock `sed` on macOS, doesn't understand this
notation.
Thanks for eliminating this particular GNU-ism.
OK, then I'm doubly surprised nobody has noticed and complained about
this. :)
-Peff