Re: [PATCH v3 2/7] bisect--helper: reimplement `bisect_replay` shell function in C

Hi Junio,

El dom, 24 ene 2021 a las 1:22, Junio C Hamano ([off-list ref]) escribió:

Miriam Rubio [off-list ref] writes:

quoted

From: Pranit Bauva <redacted>

Reimplement the `bisect_replay` shell function in C and also add
`--bisect-replay` subcommand to `git bisect--helper` to call it from
git-bisect.sh
...
+static int process_replay_line(struct bisect_terms *terms, struct strbuf *line)
+{
+     const char *p = line->buf + strspn(line->buf, " \t");
+
+     if ((!skip_prefix(p, "git bisect", &p) &&
+     !skip_prefix(p, "git-bisect", &p)) || !isspace(*p))
+             return 0;
+     p += strspn(p, " \t");
+
+     char *word_end = (char*)p + strcspn(p, " \t");
+     char *rev = word_end + strspn(word_end, " \t");

Are these lines new in this round?

Yes, they are a reviewer's suggestion.

These break builds with -Werror=declaration-after-statement.

Sorry about this, my compiler sometimes does not alert with some -Werror.
I have just sent a new version.
Best,
Miriam