Thread (2 messages) flat view 2 messages, 2 authors, 2021-01-25

Re: [PATCH v3 2/7] bisect--helper: reimplement `bisect_replay` shell function in C

From: Junio C Hamano <hidden>
Date: 2021-01-24 00:23:12

Miriam Rubio [off-list ref] writes:
From: Pranit Bauva <redacted>

Reimplement the `bisect_replay` shell function in C and also add
`--bisect-replay` subcommand to `git bisect--helper` to call it from
git-bisect.sh
...
+static int process_replay_line(struct bisect_terms *terms, struct strbuf *line)
+{
+	const char *p = line->buf + strspn(line->buf, " \t");
+
+	if ((!skip_prefix(p, "git bisect", &p) &&
+	!skip_prefix(p, "git-bisect", &p)) || !isspace(*p))
+		return 0;
+	p += strspn(p, " \t");
+
+	char *word_end = (char*)p + strcspn(p, " \t");
+	char *rev = word_end + strspn(word_end, " \t");
Are these lines new in this round?

These break builds with -Werror=declaration-after-statement.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help