Re: [PATCH v2 1/1] builtin/pack-objects.c: avoid iterating all refs

On Wed, Jan 20, 2021 at 11:19:41AM -0500, Taylor Blau wrote:

On Wed, Jan 20, 2021 at 11:18:11AM -0500, Jeff King wrote:

quoted

So I think both the existing and the new calls using for_each_tag_ref()
are OK here.

Indeed, I followed the same trail of calls as you did and reached the
same conclusion, but didn't write any of it down here since I thought it
wasn't worthwhile.

But, yes, I agree that both are safe.

OK. I think it's worth saying such things (in case that was not obvious.
;) ).

I also rage-replaced peel_ref() with a function taking an oid so we
never have to do that digging again. Posted separately in its own
thread.

-Peff