Thread (132 messages) flat view 132 messages, 6 authors, 2021-01-20

Re: [RFC/PATCH 05/12] mktag tests: remove needless SHA-1 hardcoding

From: Jeff King <hidden>
Date: 2020-11-26 07:49:33

On Thu, Nov 26, 2020 at 02:28:47AM +0100, Ævar Arnfjörð Bjarmason wrote:
But here we're testing for a SHA-length string which contains
characters outside of the /[0-9a-f]/i set. Let's just do that with a
ROT13 invocation.

We could get really unlucky and switch to a future hash function that
just happens to produce all [0-9] output for this particular input,
but that's very unlikely.
Maybe s/[0-9a-f]/z/ would be both simpler and more robust?

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help