[RFC/PATCH 06/12] mktag tests: improve verify_object() test coverage
STALE2080d
From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2020-11-26 01:29:18
Subsystem:
the rest · Maintainer:
Linus Torvalds
The verify_object() function in "mktag.c" is tasked with ensuring that our tag refers to a valid object. The existing test for this might fail because it was also testing that "type taggg" didn't refer to a valid object type (it should be "type tag"). Let's split these tests up, so we're testing all combinations of a non-existing object and in invalid "type" line. Signed-off-by: Ævar Arnfjörð Bjarmason <redacted> --- t/t3800-mktag.sh | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)
diff --git a/t/t3800-mktag.sh b/t/t3800-mktag.sh
index b5013af2aa..3801d3a285 100755
--- a/t/t3800-mktag.sh
+++ b/t/t3800-mktag.sh@@ -128,6 +128,28 @@ check_verify_failure '"type" line type-name length check' \ ############################################################ # 9. verify object (SHA1/type) check +cat >tag.sig <<EOF +object $(test_oid deadbeef) +type tag +tag mytag +tagger . <> 0 +0000 + +EOF + +check_verify_failure 'verify object (SHA1/type) check' \ + '^error: char7: could not verify object.*$' + +cat >tag.sig <<EOF +object $head +type tagggg +tag mytag +tagger . <> 0 +0000 + +EOF + +check_verify_failure 'verify object (SHA1/type) check' \ + '^fatal: invalid object type' + cat >tag.sig <<EOF object $(test_oid deadbeef) type tagggg
--
2.29.2.222.g5d2a92d10f8