Re: [PATCH v2 07/11] add -p (built-in): do not color the progress indicator separately

Hi Phillip,

On Fri, 13 Nov 2020, Phillip Wood wrote:

On 13/11/2020 13:57, Johannes Schindelin wrote:

quoted

On Fri, 13 Nov 2020, Phillip Wood wrote:

quoted

On 11/11/2020 12:28, Johannes Schindelin via GitGitGadget wrote:

quoted

From: Johannes Schindelin <redacted>

The Perl version of this command colors the progress indicator and the
prompt message in one go, let's do the same in the built-in version.

Why? the C version has access to an api that means we don't have to
remember to print the reset string each time so why move away from
that? I don't think it matters to the user that there are some extra
escape codes in the prompt of the C version. The answer is probably
"so we can use the same test as the perl version" which might be a
good reason - if it is I think it would be helpful to say so in the
commit message.

Honestly, the number one reason is so that the _same_ test passes using
the Perl version as well as with the built-in version, something that is
required by the `linux-clang` job in our CI build.

That's what I assumed - it would be good to document that in the commit
message.

I did that:

    add -p (built-in): do not color the progress indicator separately

    The Perl version of this command colors the progress indicator and the
    prompt message in one go.

    Let's do the same in the built-in version so that the same upcoming test
    (which will compare the output of `git add -p` against a known-good
    version) will pass both for the Perl version as well as for the built-in
    version.

quoted

I am not really willing to change this, unless I hear a goooood reason to
complicate the test.

I guess we could change the perl version to match the C version as it is the
perl version that will be retired but I'm not that fussed

Well, since we want to supersede the Perl version by the built-in version,
the latter needs to imitate the former, no?

Ciao,
Dscho