Re: [PATCH v2 3/3] test-lib: reduce verbosity of skipped tests

On Wed, Oct 14, 2020 at 10:55 AM Jeff King [off-list ref] wrote:

On Wed, Oct 14, 2020 at 10:39:01AM -0700, Elijah Newren wrote:

quoted

On Wed, Oct 14, 2020 at 9:53 AM Jeff King [off-list ref] wrote:

quoted

On Tue, Oct 13, 2020 at 07:19:46PM +0000, Elijah Newren via GitGitGadget wrote:

quoted

From: Elijah Newren <redacted>

When using the --run flag to run just two or three tests from a test
file which contains several dozen tests, having every skipped test print
out dozens of lines of output for the test code for that skipped test
adds up to hundreds or thousands of lines of irrelevant output that make
it very hard to fish out the relevant results you were looking for.
Simplify the output for skipped tests down to just showing the one-line
descriptions.

This last sentence is inaccurate in this version, isn't it?

Maybe I could make it clearer, but I think that it is accurate[1].  If
this wording seems confusing, though, I could simplify the commit
message by reducing the sentence to "Simplify the output for skipped
tests."

Yeah, I wondered if you might have been thinking that. It makes sense in
the context of the other discussion, but the single-line TAP output is
not even mentioned here. And it might be worth doing so, because the
real reason it is OK to delete this line entirely is that it is
redundant with that line.

Makes sense; I'll update it to mention that, once the discussion on
how we want to handle regexes/globs/subshells for patch 1/3 is
resolved.