Re: [PATCH v2 3/3] test-lib: reduce verbosity of skipped tests

On Wed, Oct 14, 2020 at 9:53 AM Jeff King [off-list ref] wrote:

On Tue, Oct 13, 2020 at 07:19:46PM +0000, Elijah Newren via GitGitGadget wrote:

quoted

From: Elijah Newren <redacted>

When using the --run flag to run just two or three tests from a test
file which contains several dozen tests, having every skipped test print
out dozens of lines of output for the test code for that skipped test
adds up to hundreds or thousands of lines of irrelevant output that make
it very hard to fish out the relevant results you were looking for.
Simplify the output for skipped tests down to just showing the one-line
descriptions.

This last sentence is inaccurate in this version, isn't it?

Maybe I could make it clearer, but I think that it is accurate[1].  If
this wording seems confusing, though, I could simplify the commit
message by reducing the sentence to "Simplify the output for skipped
tests."

[1] The original code showed the one-line description (with a
"skipping test:" prefix) AND the full test code AND then repeated the
one-line description on an "ok" line.  My v1 version of this patch
ripped out the long middle portion -- the full test code -- and thus
only showed the other bits, namely showing the one-line descriptions
twice (once with the "skipping test:" prefix, and the second time with
an "ok <number> # " prefix).  This v2 version of the patch shows the
one-line description only once with the "ok <number> #" prefix.  So,
I'd say the commit message is still accurate: the code only shows the
one-line description in both v1 and v2, though there is a question of
how many times it is shown.

Other than that, I think this is a good change (I admit I never noticed
the irrelevant output because it is only shown with "-v", and that is
already full of irrelevant bits. But I have trouble imagining how it
would be useful).

Earlier discussion mentioned shortening the "ok 2 # skip" line, but I
think removing this fd-3 version is the only sane direction. The other
one gets parsed by TAP tools like prove, and may be shown. E.g., "prove
--directive t0003-attributes.sh" shows the description of the skipped
tests (likewise, "-v" shows all tests but highlights the skipped ones).

Make sense, thanks.