Thread (2 messages) 2 messages, 2 authors, 2020-10-01

Re: [PATCH v2 06/13] reftable: (de)serialization for the polymorphic record type.

flat view

From: Junio C Hamano <hidden>
Date: 2020-10-01 19:23:28

"Han-Wen Nienhuys via GitGitGadget" [off-list ref] writes:
quoted hunk
+struct reftable_record reftable_new_record(uint8_t typ)
+{
+	struct reftable_record rec = { NULL };
I can see a lot of "sparse" inspired work went into this, but we
would want to take the previous discussion into account, as nothing
has changed since then.

https://lore.kernel.org/git/41a60e60-d2c0-7d54-5456-e44d106548a4@kdbg.org/ (local)

https://lore.kernel.org/git/1df91aa4-dda5-64da-6ae3-5d65e50a55c5@ramsayjones.plus.com/ (local)

Unfortunately we didn't reach a clear consensus back then; I thought
we saw a fix to make sparse silent when we use the "= { 0 }" idiom
in recent versions of sparse, but the above threads do not have any
mention of it, so either I am misremembering or there were other
discussions on the same topic where it was also mentioned.
+	switch (typ) {
Need blank before this line.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help