Re: [PATCH] range-diff: fix some 'hdr-check' and sparse warnings
From: Johannes Sixt <hidden>
Date: 2019-07-12 05:21:12
Am 12.07.19 um 00:03 schrieb Ramsay Jones:
quoted hunk ↗ jump to hunk
diff --git a/range-diff.c b/range-diff.c index ba1e9a4265..0f24a4ad12 100644 --- a/range-diff.c +++ b/range-diff.c@@ -102,7 +102,7 @@ static int read_patches(const char *range, struct string_list *list) } if (starts_with(line, "diff --git")) { - struct patch patch = { 0 }; + struct patch patch = { NULL };
There is nothing wrong with 0 here. IMHO, zero-initialization should
*always* be written as = { 0 } and nothing else. Changing 0 to NULL to
pacify sparse encourages a wrong style.
-- Hannes