Hi Alban and Peff,

On Fri, Jul 31, 2020 at 7:45 PM Jeff King [off-list ref] wrote:

On Fri, Jul 31, 2020 at 07:37:22PM +0200, Alban Gruin wrote:

quoted

quoted

+           # Leave $expect unquoted to lose possible leading whitespaces
+           echo $expect >expected
+           test_expect_${4:-sucess} $PREREQ "basic atom: $1 contents:size" '

There is a typo here, and $expect is written to `expected', but
`test_cmp' wants `expect'.  Fixing those mistakes does not reveal any
broken tests.

I thought at first you meant that the typo was s/expected/expect, and
wondered how this could possibly have passed. But the typo is
s/sucess/success/, so we were in fact not running the test at all (and
were generating "test_expect_sucess: not found" messages to stderr, but
outside of any test block. Yikes.

Thanks for spotting.

Yeah, I copied a suggestion from Junio in the last iteration without
properly checking it. Sorry about that and thanks for spotting and
fixing it.