Thread (21 messages) 21 messages, 3 authors, 2020-07-31

Re: [PATCH v5 3/3] ref-filter: add support for %(contents:size)

From: Jeff King <hidden>
Date: 2020-07-31 17:45:49

On Fri, Jul 31, 2020 at 07:37:22PM +0200, Alban Gruin wrote:
quoted
+		# Leave $expect unquoted to lose possible leading whitespaces
+		echo $expect >expected
+		test_expect_${4:-sucess} $PREREQ "basic atom: $1 contents:size" '
There is a typo here, and $expect is written to `expected', but
`test_cmp' wants `expect'.  Fixing those mistakes does not reveal any
broken tests.
I thought at first you meant that the typo was s/expected/expect, and
wondered how this could possibly have passed. But the typo is
s/sucess/success/, so we were in fact not running the test at all (and
were generating "test_expect_sucess: not found" messages to stderr, but
outside of any test block. Yikes.

Thanks for spotting.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help