Thread (58 messages) flat view 58 messages, 2 authors, 2020-07-26

Re: [PATCH v4 37/39] ci: run tests with SHA-256

From: Eric Sunshine <hidden>
Date: 2020-07-26 23:55:08

On Sun, Jul 26, 2020 at 3:56 PM brian m. carlson
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
Now that we have Git supporting SHA-256, we'd like to make sure that we
don't regress that state.  Unfortunately, it's easy to do so, so to
help, let's add code to run one of our CI jobs with SHA-256 as the
default hash.  This will help us detect any problems that may occur.

We pick the linux-clang job because it's relatively fast and the
linux-gcc job already runs the testsuite twice.  We want our tests to
run as fast as possible, so we wouldn't want to add a third run to the
linux-gcc job.  To make sure we properly exercise the code, let's run
the tests in the default mode (SHA-1) first and then run a second time
with SHA-256.

Signed-off-by: brian m. carlson <redacted>
---
diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh
@@ -24,6 +24,11 @@ linux-gcc)
+linux-clang)
+       make test
+       export GIT_TEST_DEFAULT_HASH=sha256
+       make test
+       ;;
If the default someday flips from sha1 to sha256, then this will
merely run the entire test suite twice with SHA-256. Perhaps it could
be more explicit like this:

    export GIT_TEST_DEFAULT_HASH=sha1
    make test
    export GIT_TEST_DEFAULT_HASH=sha256
    make test
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help