Thread (58 messages) flat view 58 messages, 2 authors, 2020-07-26

Re: [PATCH v4 11/39] t7063: make hash size independent

From: Eric Sunshine <hidden>
Date: 2020-07-26 22:40:24

On Sun, Jul 26, 2020 at 3:55 PM brian m. carlson
[off-list ref] wrote:
Use test_oid instead of hard-coding a fixed size all-zeros object ID.
This patch is doing more than replacing all-zero OID's. Perhaps say instead:

    Use test_oid instead of hard-coding SHA-1-specific OID's.

or something.
quoted hunk ↗ jump to hunk
Signed-off-by: brian m. carlson <redacted>
---
diff --git a/t/t7063-status-untracked-cache.sh b/t/t7063-status-untracked-cache.sh
@@ -695,6 +705,7 @@ test_expect_success 'using --untracked-cache does not fail when core.untrackedCa
 test_expect_success 'setting core.untrackedCache to keep' '
+       touch ../expect-from-test-dump &&
This change seems unrelated to all other changes in this patch.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help