Thread (9 messages) 9 messages, 3 authors, 2020-05-05
STALE2254d

[PATCH 4/6] fixup! Add reftable library

From: Johannes Schindelin via GitGitGadget <hidden>
Date: 2020-05-04 13:31:35
Subsystem: the rest · Maintainer: Linus Torvalds

From: Johannes Schindelin <redacted>

`usleep()` is unportable. We need to find a way _not_ to use it.

For Visual C, we can use `sleep_millisec()`, but the current design of
libreftable seems to be _really_ keen _not_ to depend on anything in
libgit.a.

Signed-off-by: Johannes Schindelin <redacted>
---
 reftable/stack.c | 5 +++++
 1 file changed, 5 insertions(+)
diff --git a/reftable/stack.c b/reftable/stack.c
index 3c5f4a43130..2d0b831dda1 100644
--- a/reftable/stack.c
+++ b/reftable/stack.c
@@ -289,7 +289,12 @@ static int reftable_stack_reload_maybe_reuse(struct reftable_stack *st,
 		free_names(names_after);
 
 		delay = delay + (delay * rand()) / RAND_MAX + 100;
+#ifdef _MSC_VER
+		sleep_millisec(delay/1000);
+#else
+		/* TODO! fix this, `usleep()` is not portable enough for us to use */
 		usleep(delay);
+#endif
 	}
 
 	return 0;
-- 
gitgitgadget
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help