Thread (9 messages) 9 messages, 3 authors, 2020-05-05
STALE2237d

[PATCH 1/6] fixup! Add reftable library

From: Johannes Schindelin via GitGitGadget <hidden>
Date: 2020-05-04 13:31:30
Subsystem: the rest · Maintainer: Linus Torvalds

From: Johannes Schindelin <redacted>

Close files before trying to unlink them. This is actually required on
Windows.

Note: this is probably not the only part of the code that requires this
type of fix, but it seems to be enough to let the _current_ version of
t0031 pass.

Signed-off-by: Johannes Schindelin <redacted>
---
 reftable/stack.c | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/reftable/stack.c b/reftable/stack.c
index e7b625d924a..2e32f7671c2 100644
--- a/reftable/stack.c
+++ b/reftable/stack.c
@@ -852,6 +852,10 @@ static int stack_compact_range(struct reftable_stack *st, int first, int last,
 		}
 	}
 
+	if (lock_file_fd > 0) {
+		close(lock_file_fd);
+		lock_file_fd = 0;
+	}
 	err = unlink(slice_as_string(&lock_file_name));
 	if (err < 0) {
 		goto exit;
-- 
gitgitgadget
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help