Re: [PATCH 3/8] t7508: don't use `test_must_fail test_cmp`
From: Johannes Sixt <hidden>
Date: 2020-04-21 20:59:54
Am 20.04.20 um 10:54 schrieb Denton Liu:
quoted hunk ↗ jump to hunk
--- a/t/t7508-status.sh +++ b/t/t7508-status.sh@@ -1471,7 +1471,7 @@ test_expect_success '"status.branch=true" same as "-b"' ' test_expect_success '"status.branch=true" different from "--no-branch"' ' git status -s --no-branch >expected_nobranch && git -c status.branch=true status -s >actual && - test_must_fail test_cmp expected_nobranch actual + ! test_cmp expected_nobranch actual '
Not your fault, but this is, of course, a very weak test case. Check that some output that the program generates is _not_ equal to something else? That condition should be very easy to satisfy. -- Hannes