Re: [PATCH 6/8] t9164: don't use `test_must_fail test_cmp`
From: Eric Sunshine <hidden>
Date: 2020-04-20 16:21:51
On Mon, Apr 20, 2020 at 4:55 AM Denton Liu [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The test_must_fail function should only be used for git commands since we assume that external commands work sanely. Since test_cmp() just wraps an external command, replace `test_must_fail test_cmp` with `! test_cmp`. Signed-off-by: Denton Liu <redacted> ---diff --git a/t/t9164-git-svn-dcommit-concurrent.sh b/t/t9164-git-svn-dcommit-concurrent.sh@@ -103,7 +103,7 @@ test_expect_success 'check if pre-commit hook fails' ' - test_must_fail svn_cmd commit -m "this commit should fail" && + ! svn_cmd commit -m "this commit should fail" &&
Hmm, this doesn't look like 'test_cmp' mentioned in the commit message.