Thread (27 messages) 27 messages, 4 authors, 2019-11-26

Re: [PATCH 1/1] commit-graph: use start_delayed_progress()

From: Derrick Stolee <hidden>
Date: 2019-11-05 17:38:13

On 11/5/2019 11:05 AM, Derrick Stolee via GitGitGadget wrote:
From: Derrick Stolee <redacted>

When writing a commit-graph, we show progress along several commit
walks. When we use start_delayed_progress(), the progress line will
only appear if that step takes a decent amount of time.

However, one place was missed: computing generation numbers. This is
normally a very fast operation as all commits have been parsed in a
previous step. But, this is showing up for all users no matter how few
commits are being added.
For course, now that we do not force at least one progress line to show
up, the tests that check the `--progress` option (or `--no-quiet` for GC)
will fail with this patch.

v2 coming soon.

-Stolee
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help