[PATCH 1/1] commit-graph: use start_delayed_progress()
From: Derrick Stolee via GitGitGadget <hidden>
Date: 2019-11-05 16:06:00
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Derrick Stolee via GitGitGadget <hidden>
Date: 2019-11-05 16:06:00
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Derrick Stolee <redacted> When writing a commit-graph, we show progress along several commit walks. When we use start_delayed_progress(), the progress line will only appear if that step takes a decent amount of time. However, one place was missed: computing generation numbers. This is normally a very fast operation as all commits have been parsed in a previous step. But, this is showing up for all users no matter how few commits are being added. Reported-by: ryenus <redacted> Signed-off-by: Derrick Stolee <redacted> --- commit-graph.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/commit-graph.c b/commit-graph.c
index 0aea7b2ae5..071e1c6e9b 100644
--- a/commit-graph.c
+++ b/commit-graph.c@@ -1103,7 +1103,7 @@ static void compute_generation_numbers(struct write_commit_graph_context *ctx) struct commit_list *list = NULL; if (ctx->report_progress) - ctx->progress = start_progress( + ctx->progress = start_delayed_progress( _("Computing commit graph generation numbers"), ctx->commits.nr); for (i = 0; i < ctx->commits.nr; i++) {
--
gitgitgadget