Thread (190 messages) 190 messages, 7 authors, 2019-11-21

Re: [PATCH 4/9] sparse-checkout: 'add' subcommand

From: Elijah Newren <hidden>
Date: 2019-09-18 14:56:42

On Wed, Sep 18, 2019 at 6:55 AM Derrick Stolee [off-list ref] wrote:
On 8/23/2019 7:30 PM, Elijah Newren wrote:
quoted
On Tue, Aug 20, 2019 at 8:12 AM Derrick Stolee via GitGitGadget
[off-list ref] wrote:
quoted
...
quoted
quoted
diff --git a/t/t1091-sparse-checkout-builtin.sh b/t/t1091-sparse-checkout-builtin.sh
index b7d5f15830..499bd8d6d0 100755
--- a/t/t1091-sparse-checkout-builtin.sh
+++ b/t/t1091-sparse-checkout-builtin.sh
@@ -100,4 +100,24 @@ test_expect_success 'clone --sparse' '
        test_cmp expect dir
 '

+test_expect_success 'add to existing sparse-checkout' '
+       echo "/folder2/*" | git -C repo sparse-checkout add &&
I've always been using '/folder2/' in sparse-checkout, without the
trailing asterisk.  That seems more friendly for cone mode too.  Are
there benefits to keeping the trailing asterisk?
I think I've been seeing issues with pattern matching on Windows without
the trailing asterisk. I'm currently double-checking to make sure this
is important or not.
Can you try with the en/clean-nested-with-ignored topic in pu to see
if that fixes those issues?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help