On Wed, Jun 12, 2019 at 09:14:40PM +0200, Johannes Schindelin wrote:

Hi,

On Tue, 11 Jun 2019, SZEDER Gábor wrote:

quoted

On Tue, Jun 11, 2019 at 01:36:16PM -0700, Junio C Hamano wrote:

quoted

SZEDER Gábor [off-list ref] writes:

quoted

-Rebasing (1/4)QRebasing (2/4)QRebasing (3/4)QRebasing (4/4)QSuccessfully rebased and updated refs/heads/missing-commit.
+Rebasing (1/4)QRebasing (2/4)QRebasing (3/4)QRebasing (4/4)QQ                                                                                QSuccessfully rebased and updated refs/heads/missing-commit.
 EOF

Yuck,

Oh yeah...

quoted

... but I do not see how else/better this test can be written
myself, which makes it a double-yuck X-<

Perhaps hiding those spaces behind a helper variable e.g.
'dump_term_clear_line=Q<80-spaces>Q' and embedding that in the here
docs specifying the expected output in these three tests could make it
ever so slightly less yuck...

quoted

Are we forcing out test to operate under dumb terminal mode and with
a known number of columns?

'test-lib.sh' sets TERM=dumb relatively early on, and in these tests
we don't use 'test_terminal' to run 'git rebase', so...  yeah.  And
term_columns() defaults to 80.

However, if the terminal were smart, then we would have to deal with
ANSI escape suddenly popping up...

And I fear that is *exactly* what makes
https://dev.azure.com/gitgitgadget/git/_build/results?buildId=10539&view=ms.vss-test-web.build-test-results-tab
fail...

Isn't it a sign of a problem in that Windows test environment that
it mistakenly believes that the terminal is smart, even though it has
been explicitly set to dumb?