Thread (16 messages) 16 messages, 4 authors, 2019-06-25

Re: [PATCH v2 3/4] rebase: fix garbled progress display with '-x'

From: SZEDER Gábor <hidden>
Date: 2019-06-11 21:11:57

Possibly related (same subject, not in this thread)

On Tue, Jun 11, 2019 at 01:36:16PM -0700, Junio C Hamano wrote:
SZEDER Gábor [off-list ref] writes:
quoted
-Rebasing (1/4)QRebasing (2/4)QRebasing (3/4)QRebasing (4/4)QSuccessfully rebased and updated refs/heads/missing-commit.
+Rebasing (1/4)QRebasing (2/4)QRebasing (3/4)QRebasing (4/4)QQ                                                                                QSuccessfully rebased and updated refs/heads/missing-commit.
 EOF
Yuck, 
Oh yeah...
... but I do not see how else/better this test can be written
myself, which makes it a double-yuck X-<
Perhaps hiding those spaces behind a helper variable e.g.
'dump_term_clear_line=Q<80-spaces>Q' and embedding that in the here
docs specifying the expected output in these three tests could make it
ever so slightly less yuck...
Are we forcing out test to operate under dumb terminal mode and with
a known number of columns?
'test-lib.sh' sets TERM=dumb relatively early on, and in these tests
we don't use 'test_terminal' to run 'git rebase', so...  yeah.  And
term_columns() defaults to 80.

However, if the terminal were smart, then we would have to deal with
ANSI escape suddenly popping up...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help