Re: [PATCH v3] repack: enable bitmaps by default on bare repos
From: Jeff King <hidden>
Date: 2019-05-08 22:25:06
On Wed, May 08, 2019 at 06:13:58PM +0200, Ævar Arnfjörð Bjarmason wrote:
quoted
I do wonder if this really needs to be part of the progress bar. The goal of the progress bar is to give the user a sense that work is happening, and (if possible, but not for "enumerating") an idea of when it might finish. If the trace code can already do detailed timings, then shouldn't we just be encouraging people to use that?[...] - progress->title = title; + progress->title = "Reticulating splines";
Heh, OK, that's a fair reductio ad absurdum of my point. I guess what I was trying to say is that we don't need to go overboard with accuracy as long as we're giving a vague sense of the work. Precision measurements can be handled through a different system. But I don't mind if you can find a way to do these kind of cascaded progress meters in a way that is pleasing to the eye and not hard to handle in the callers of the code. -Peff