Re: [PATCH v4 3/3] range-diff: make diff option behavior (e.g. --stat) consistent
From: Eric Sunshine <hidden>
Date: 2018-11-11 08:44:04
On Fri, Nov 9, 2018 at 5:18 AM Ævar Arnfjörð Bjarmason [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Make the behavior when diff options (e.g. "--stat") are passed consistent with how "diff" behaves. [...] Signed-off-by: Ævar Arnfjörð Bjarmason <redacted> ---diff --git a/range-diff.c b/range-diff.c@@ -453,7 +453,8 @@ int show_range_diff(const char *range1, const char *range2, - opts.output_format |= DIFF_FORMAT_PATCH; + if (!opts.output_format) + opts.output_format |= DIFF_FORMAT_PATCH;
I think this can just be '=' now instead of '|=' (to avoid confusing the reader, even if it's functionally equivalent).